Skip to content

Conversation

pboling
Copy link

@pboling pboling commented Oct 22, 2014

• Adds benchmark option
• Adds more tests

Adds more tests;
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@pboling
Copy link
Author

pboling commented Oct 22, 2014

Travis build is finished and passed... not sure why github isn't reporting that correctly.

@atandon
Copy link

atandon commented Oct 23, 2014

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a test for this too?

@zpao
Copy link
Member

zpao commented Dec 8, 2014

I'd prefer if these were done separately since they are quite discrete tasks but meh, this is fine. I think just address the things @vipulnsward said and we can merge this.

@pboling
Copy link
Author

pboling commented Dec 9, 2014

I'll try to get to this in the next week or so.

@pboling
Copy link
Author

pboling commented Jun 21, 2015

Building a better boat here: https://github.com/pboling/react-rails-benchmark_renderer

It requires the ServerRendering refactor, so please release it soon!

@pboling pboling closed this Jun 21, 2015
@rmosolgo
Copy link
Member

Very cool! Glad to see those refactors are paying off.

Yes, I want to get a new version out soon, but we're blocked behind rails/sprockets-rails#257 (And I don't have the nerve to dive in and figure it out!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants